Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The word landmark is no longer abbreviated in braille #13158

Closed
dkager opened this issue Dec 10, 2021 · 4 comments
Closed

The word landmark is no longer abbreviated in braille #13158

dkager opened this issue Dec 10, 2021 · 4 comments
Milestone
2021.3.1

Comments

@dkager
Copy link
Collaborator

dkager commented Dec 10, 2021

Steps to reproduce:

  1. Connect a braille display.
  2. Go to www.nvaccess.org.
  3. Ensure that browse mode is turned on.
  4. Press Ctrl+Home.

Actual behavior:

The braille display shows:
"landmark navi h1 lnk gra NV Access"

Expected behavior:

The display shows:
"lmk navi h1 lnk gra NV Access"
That is, "landmark" should be "lmk", just as "navigation" is shortened to "navi".

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

2021.3

Windows version:

Windows 10 21H2 (10.0.19044) workstation

Name and version of other software in use when reproducing the issue:

Firefox 95.0

Other information about your system:

N/A

Other questions

Does the issue still occur after restarting your computer?

Yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

Yes, "lmk" is shown in 2021.2 and the release notes does not mention this change.

If NVDA add-ons are disabled, is your problem still occurring?

Yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Yes
@dkager
Copy link
Collaborator Author

dkager commented Dec 10, 2021

It looks like getControlFieldBraille retrieves controlTypes.Role.LANDMARK.displayString, but the value from braille.roleLabels should probably be used.

@lukaszgo1 lukaszgo1 mentioned this issue Dec 12, 2021
Merged
5 tasks
@nvaccessAuto nvaccessAuto added this to the 2022.1 milestone Dec 13, 2021
feerrenrut pushed a commit that referenced this issue Dec 14, 2021
@lukaszgo1 @feerrenrut
Ensure that role label for landmark is once again abbreviated in brai…
7f2d8b4 
…lle (PR #13160)

Fixes #13158

PR #12814 replaced usages of deprecated controlTypes.roleLabels with role.displayString. However braille has its own mapping of roles to labels which should be used for abbreviations of roles for braille. The role label used for speech has been mistakenly used for a role of landmark.
@feerrenrut feerrenrut modified the milestones: 2022.1, 2021.3.1 Dec 14, 2021
@feerrenrut
Copy link
Contributor

Please test and confirm this is fixed in the RC for 2021.3.1: https://www.nvaccess.org/post/nvda-2021-3-1rc1/

@lukaszgo1
Copy link
Contributor

Confirmed as fixed.

@dkager
Copy link
Collaborator Author

dkager commented Dec 14, 2021

I can confirm that this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2021.3.1
Development

No branches or pull requests
4 participants
@dkager @feerrenrut @lukaszgo1 @nvaccessAuto